update doc model_diva.py #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 129 129
Lines 4464 4464
=======================================
Hits 4250 4250
Misses 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
smilesun
reviewed
Sep 1, 2023
domainlab/models/model_diva.py
Outdated
| zd_dim: size of latent space for domain-specific information, | ||
| zy_dim: size of latent space for class-specific information, | ||
| zx_dim: size of latent space for residual variance, | ||
| chain_node_builder: TODO, |
There was a problem hiding this comment.
We can either first merge the new node handler you are implmenting into master, then update this branch
There was a problem hiding this comment.
yes, I will first complete the test file and then update the doc again after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.